[DT-2757] Ensure institutional Certification files are saved on appropriate dataset updates #2771
Conversation
| throws IOException { | ||
| List<FileStorageObject> updateDatasetFSOs = new ArrayList<>(); | ||
|
|
||
| if (files.containsKey(String.format(NIH_INSTITUTIONAL_CERTIFICATION_NAME, 0))) { |
There was a problem hiding this comment.
This is the core of the bug. When multiple datasets are updated, we can have multiple files submitted. Assuming the files key was always consentGroups[**0**].nihInstitutionalCertificationFile is incorrect. The update payload might be just a change for consentGroup[5], or a case where multiple consentGroup entries are updated at the same time.
Given this bug I've made https://broadworkbench.atlassian.net/browse/DT-2759
otchet-broad
requested review from
eweitz,
fboulnois,
kevinmarete and
rushtong
and removed request for
a team
|
| datasetUpdate.dacId, | ||
| datasetUpdate.props, | ||
| studyUpdate.files, | ||
| datasetUpdate.files, |
There was a problem hiding this comment.
Passing the studyUpdate files into the dataset updates (and inserts ~L271) was also problematic. The files would be uploaded to GCS but the FSOs wouldn't be recorded.
otchet-broad
deleted the
otchet-dt-2757-save-institutional-ceritification-updates
branch
Addresses
https://broadworkbench.atlassian.net/browse/DT-2757
Summary
Updates to documents were only being saved for the first dataset on a study.
Have you read CONTRIBUTING.md lately? If not, do that first.